Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Paypal] send valid error_reason in all the error responses #1914

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

send valid error_reason in all the error responses

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
image

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 10, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Aug 10, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner August 10, 2023 13:20
@SanchithHegde SanchithHegde added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 3df9441 Aug 10, 2023
10 of 14 checks passed
@SanchithHegde SanchithHegde deleted the fix-payal-error-reason branch August 10, 2023 18:47
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants