-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add psync for multiple partial captures #1934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PaymentCaptures get_tracker
… logic to a separate function
… logic to a separate function
jarnura
requested changes
Aug 22, 2023
Narayanbhat166
previously approved these changes
Aug 22, 2023
jarnura
approved these changes
Aug 22, 2023
Narayanbhat166
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently there is no implementation for syncing payments with multiple partial captures.
In this pr I have added support for the same.
For any payment involving multiple partial captures, we will sync each capture with the connector and then update the attempt_status based on all capture status and total captured amount.
Additional Changes
Motivation and Context
How did you test it?
Manual
![Screenshot 2023-08-16 at 1 36 53 AM](https://private-user-images.githubusercontent.com/61539176/260827901-66738990-3b0c-4ad8-980a-a86086d237ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5OTIyNDQsIm5iZiI6MTcyMzk5MTk0NCwicGF0aCI6Ii82MTUzOTE3Ni8yNjA4Mjc5MDEtNjY3Mzg5OTAtM2IwYy00YWQ4LTk4MGEtYTg2MDg2ZDIzN2FkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE0MzkwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc1N2EwODRiNjVhOTQxNmI2NzExYzJjNzU2MmE3ZTZiN2YyZmE5ODc3NzNjZWUwNTNlMjY5Yzg5NDBjYjYxY2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bso9kmoSOXirZMbaGESUYT10acHzst_QXUuGwFi0AAg)
Checklist
cargo +nightly fmt --all
cargo clippy