Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add psync for multiple partial captures #1934

Merged
merged 59 commits into from
Aug 23, 2023
Merged

feat(core): add psync for multiple partial captures #1934

merged 59 commits into from
Aug 23, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Aug 15, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently there is no implementation for syncing payments with multiple partial captures.
In this pr I have added support for the same.
For any payment involving multiple partial captures, we will sync each capture with the connector and then update the attempt_status based on all capture status and total captured amount.

  • Some connectors can fetch all captures for a payment in a single get request. For such connectors the status update for each pending captures should be made at the connector side.
  • For connector that can only do sync on individual captures, That logic is handled at core.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual
Screenshot 2023-08-16 at 1 36 53 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026
feature(router): create capture entity for each manual capture request
c1a314a
@hrithikesh026
Merge branch 'main' into create-child-payment-intent-for-capture
fbe6585
@hrithikesh026
fix: copy amount_to_capture from payment_attempt to amount in capture
28e26a8
@hrithikesh026
chore: spell check
9b82fd9
@hrithikesh026
fix: cargo c with --no-default-features was failing
b426172
@hrithikesh026
fix: implement find all for Capture
2c78714
@hrithikesh026
chore: remove println
d762531
@hrithikesh026
chore: +nightly fmt
40abc4e
@hrithikesh026
fix(core): add validation and status update logic to multiple partial…
975d90d 
… capture
@hrithikesh026
chore: resolve conflicts
37579f5
@hrithikesh026
chore: address spell
749a1c8
@hrithikesh026
chore; address migration changes
0d0242b
@hrithikesh026
chore: generate openapi
b0fa57b
@hrithikesh026
git diff
5985a82
@hrithikesh026
fix: migration
fed79e4
@hrithikesh026
fix: implement functions for Store for feature not kv_store
dd9614c
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
bc62c42
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
c199507
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
9007411
@hrithikesh026
fix(core): use capture_id as primany key instead of auto incremented …
49a6df5 
…id value
@hrithikesh026
fix: change function name in feature 'not kv_store'
0936d2c
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
5b9678b
@hrithikesh026
refactor: enum CaptureUpdate
ad43841
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
83d446e
@hrithikesh026
fix: make connector field non updateable in captures table
481da16
@hrithikesh026
feat(router): support for multiple partial captures
93c485e
@hrithikesh026
fix: repopulate amount_to_capture in payment_attempt after update in …
f02a874 
…PaymentCaptures get_tracker
@hrithikesh026
fix: implement CaptureInterface for Store for feature not kv_Store
eff015c
@hrithikesh026
feat(router): add support for multiple partial capture
2f94680
@hrithikesh026
chore: generate openapi_spec file
c3c874b
@hrithikesh026 hrithikesh026 added M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 21, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Aug 22, 2023
View reviewed changes
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 5657ad6 Aug 23, 2023
12 checks passed
@Narayanbhat166 Narayanbhat166 deleted the psync_for_multiple_partial_captures branch August 23, 2023 05:01
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@sai-harsha-vardhan sai-harsha-vardhan Awaiting requested review from sai-harsha-vardhan

Assignees

@hrithikesh026 hrithikesh026

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hrithikesh026 @jarnura @Narayanbhat166 @SanchithHegde