Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): conditionally return captures list during payment sync. #2033

Merged
merged 55 commits into from
Aug 29, 2023
Merged

feat(core): conditionally return captures list during payment sync. #2033

merged 55 commits into from
Aug 29, 2023

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

If during Psync, merchant wants to view list of all captures done on the latest attempt, they can send a query parameter called expand_captures(boolean). If true a list of captures will be included in response body.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Manual.
With expand_captures=false
Screenshot 2023-08-28 at 4 40 46 PM

With expand_captures=true
Screenshot 2023-08-28 at 4 41 04 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026
feature(router): create capture entity for each manual capture request
c1a314a
@hrithikesh026
Merge branch 'main' into create-child-payment-intent-for-capture
fbe6585
@hrithikesh026
fix: copy amount_to_capture from payment_attempt to amount in capture
28e26a8
@hrithikesh026
chore: spell check
9b82fd9
@hrithikesh026
fix: cargo c with --no-default-features was failing
b426172
@hrithikesh026
fix: implement find all for Capture
2c78714
@hrithikesh026
chore: remove println
d762531
@hrithikesh026
chore: +nightly fmt
40abc4e
@hrithikesh026
fix(core): add validation and status update logic to multiple partial…
975d90d 
… capture
@hrithikesh026
chore: resolve conflicts
37579f5
@hrithikesh026
chore: address spell
749a1c8
@hrithikesh026
chore; address migration changes
0d0242b
@hrithikesh026
chore: generate openapi
b0fa57b
@hrithikesh026
git diff
5985a82
@hrithikesh026
fix: migration
fed79e4
@hrithikesh026
fix: implement functions for Store for feature not kv_store
dd9614c
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
bc62c42
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
c199507
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
9007411
@hrithikesh026
fix(core): use capture_id as primany key instead of auto incremented …
49a6df5 
…id value
@hrithikesh026
fix: change function name in feature 'not kv_store'
0936d2c
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
5b9678b
@hrithikesh026
refactor: enum CaptureUpdate
ad43841
@hrithikesh026
Merge branch 'main' into add-validation-for-multiple-capture
83d446e
@hrithikesh026
fix: make connector field non updateable in captures table
481da16
@hrithikesh026
feat(router): support for multiple partial captures
93c485e
@hrithikesh026
fix: repopulate amount_to_capture in payment_attempt after update in …
f02a874 
…PaymentCaptures get_tracker
@hrithikesh026
fix: implement CaptureInterface for Store for feature not kv_Store
eff015c
@hrithikesh026
feat(router): add support for multiple partial capture
2f94680
@hrithikesh026
chore: generate openapi_spec file
c3c874b
@hrithikesh026 hrithikesh026 added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 28, 2023
@hrithikesh026 hrithikesh026 added this to the August 2023 Milestone milestone Aug 28, 2023
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner August 28, 2023 11:13
@hrithikesh026 hrithikesh026 self-assigned this Aug 28, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners August 28, 2023 11:13
@hrithikesh026 hrithikesh026 mentioned this pull request Aug 28, 2023
Closed
15 tasks
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit c2aa014 Aug 29, 2023
18 of 20 checks passed
@Narayanbhat166 Narayanbhat166 deleted the conditionally_return_captures_list branch August 29, 2023 14:48
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 30, 2023
lsampras pushed a commit that referenced this pull request Sep 4, 2023
@hrithikesh026 @lsampras
feat(core): conditionally return captures list during payment sync. (#…
7423487 
…2033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@sai-harsha-vardhan sai-harsha-vardhan Awaiting requested review from sai-harsha-vardhan

Assignees

@hrithikesh026 hrithikesh026

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hrithikesh026 @jarnura @Narayanbhat166 @SanchithHegde @bernard-eugine