Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): conditionally return captures list during payment sync. #2033

Merged
merged 55 commits into from
Aug 29, 2023

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

If during Psync, merchant wants to view list of all captures done on the latest attempt, they can send a query parameter called expand_captures(boolean). If true a list of captures will be included in response body.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Manual.
With expand_captures=false
Screenshot 2023-08-28 at 4 40 46 PM

With expand_captures=true
Screenshot 2023-08-28 at 4 41 04 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 28, 2023
@hrithikesh026 hrithikesh026 added this to the August 2023 Milestone milestone Aug 28, 2023
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner August 28, 2023 11:13
@hrithikesh026 hrithikesh026 self-assigned this Aug 28, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners August 28, 2023 11:13
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit c2aa014 Aug 29, 2023
18 of 20 checks passed
@Narayanbhat166 Narayanbhat166 deleted the conditionally_return_captures_list branch August 29, 2023 14:48
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants