Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [nmi] refactor nmi and handled variants errors #2463

Merged
merged 6 commits into from
Oct 6, 2023
Merged

refactor(connector): [nmi] refactor nmi and handled variants errors #2463

merged 6 commits into from
Oct 6, 2023

Conversation

Cioraz
Copy link
Contributor

@Cioraz Cioraz commented Oct 5, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adds the error handles for all unhandled variants

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Wanted to contribute to open source

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Cioraz Cioraz requested a review from a team as a code owner October 5, 2023 15:12
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 5, 2023
@Cioraz Cioraz changed the title Issue #2276 refactor(connector): [nmi] refactor nmi and handled variants errors Oct 5, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 5, 2023
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 5, 2023
@srujanchikke srujanchikke linked an issue Oct 5, 2023 that may be closed by this pull request
[REFACTOR]: [NMI] Remove Default Case Handling #2276
Closed
2 tasks
@Cioraz
Copy link
Contributor Author

Cioraz commented Oct 5, 2023

Just a question, why did cl-pr check formatting fail even after type
cargo +nightly fmt --all

@srujanchikke
Copy link
Contributor

Just a question, why did cl-pr check formatting fail even after type cargo +nightly fmt --all

Apologies @Cioraz , There was bug regarding check formatting ci check , fix has been made . Please update the branch to make workflow work .

srujanchikke
srujanchikke reviewed Oct 5, 2023
View reviewed changes
crates/router/src/connector/nmi/transformers.rs Outdated
Comment on lines 156 to 159
Err(error_stack::report!(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "nmi",
}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@srujanchikke srujanchikke added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 5, 2023
@srujanchikke srujanchikke added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 6, 2023
SanchithHegde
SanchithHegde approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Cioraz!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 6, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 6, 2023
Merged via the queue into juspay:main with commit f364a06 Oct 6, 2023
10 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @Cioraz 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@Sakilmostak Sakilmostak mentioned this pull request Oct 13, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@Cioraz Cioraz

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [NMI] Remove Default Case Handling
4 participants
@Cioraz @srujanchikke @VedantKhairnar @SanchithHegde