refactor(connector): [trustpay] refactor trustpay and handled variants errors #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Cioraz , Could you please attach the issue that you're working on ? |
srujanchikke
reviewed
Oct 7, 2023
| | api_models::payments::BankRedirectData::OnlineBankingFpx { .. } | ||
| | api_models::payments::BankRedirectData::OnlineBankingThailand { .. } => { | ||
| Err(errors::ConnectorError::NotImplemented("Payment methods".to_string()).into()) | ||
| } |
There was a problem hiding this comment.
Same here use this functionget_unimplemented_payment_method_error_message from utils
srujanchikke
reviewed
Oct 7, 2023
srujanchikke
added
A-connector-integration
2 tasks
srujanchikke
added
the
hacktoberfest
Cioraz
force-pushed
the
refactor_trustpay
branch
from
23c3732
to
bc9cf16
Compare
|
Got my error will send the final PR with no errors in sometime |
Cioraz
force-pushed
the
refactor_trustpay
branch
from
53543e2
to
210ae65
Compare
srujanchikke
added
S-waiting-on-approval
SanchithHegde
approved these changes
Oct 8, 2023
SanchithHegde
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Handling the unhandled variants for trustpay
Issue #2287
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy