Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [OpenNode] Currency Unit Conversion #2645

Merged
merged 7 commits into from
Oct 27, 2023
Merged

feat(connector): [OpenNode] Currency Unit Conversion #2645

merged 7 commits into from
Oct 27, 2023

Conversation

SagarDevAchar
Copy link
Contributor

@SagarDevAchar SagarDevAchar commented Oct 19, 2023 •
edited by deepanshu-iiitu

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Addressing Issue: [FEATURE]: [OpenNode] Currency Unit Conversion #2240
  • Modified two files in hyperswitch/crates/router/src/connector/
    • opennode.rs
      • Implement get_currency_unit function
      • Modify ConnectorIntegration implementations for Opennode
    • opennode/transformers.rs
      • Implement OpennodeRouterData<T> structure and functionality
      • Modify implementation for OpennodePaymentsRequest

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We need to create a payment using opennode and test the currency unit from connector response and connector dashboard.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SagarDevAchar SagarDevAchar requested a review from a team as a code owner October 19, 2023 15:45
@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 19, 2023
@SanchithHegde SanchithHegde linked an issue Oct 19, 2023 that may be closed by this pull request
[FEATURE]: [OpenNode] Currency Unit Conversion #2240
Closed
2 tasks
@SanchithHegde SanchithHegde mentioned this pull request Oct 22, 2023
Closed
2 tasks
SamraatBansal
SamraatBansal requested changes Oct 25, 2023
View reviewed changes
crates/router/src/connector/opennode.rs Outdated Show resolved Hide resolved
crates/router/src/connector/opennode/transformers.rs Outdated Show resolved Hide resolved
SamraatBansal
SamraatBansal approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArjunKarthik ArjunKarthik added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 27, 2023
@preetamrevankar preetamrevankar added this pull request to the merge queue Oct 27, 2023
Merged via the queue into juspay:main with commit 88e1f29 Oct 27, 2023
11 checks passed
@deepanshu-iiitu
Copy link
Contributor

Hey @SagarDevAchar ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@swangi-kumari swangi-kumari removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 27, 2023
@SagarDevAchar SagarDevAchar deleted the opennode_issue_2240 branch October 28, 2023 02:10
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@SagarDevAchar @Abhicodes-crypto
feat(connector): [OpenNode] Currency Unit Conversion (#2645)
355511c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

Assignees

@SagarDevAchar SagarDevAchar

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [OpenNode] Currency Unit Conversion
7 participants
@SagarDevAchar @deepanshu-iiitu @ArjunKarthik @SamraatBansal @SanchithHegde @swangi-kumari @preetamrevankar