Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Airwallex] Use connector_response_reference_id as reference to merchant #2695

Closed
wants to merge 4 commits into from
Closed

feat(connector): [Airwallex] Use connector_response_reference_id as reference to merchant #2695

wants to merge 4 commits into from

Conversation

sccalabr
Copy link
Contributor

@sccalabr sccalabr commented Oct 26, 2023 •
edited by deepanshu-iiitu

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Refactored reference ids to use connector_response_reference_id

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#2322

How did you test it?

Make any Payment for connector Airwallex and see that you are getting "reference_id" field in the payments response of hyperswitch. It should not be null.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sccalabr sccalabr requested a review from a team as a code owner October 26, 2023 04:27
@sccalabr sccalabr force-pushed the issue-2322 branch 2 times, most recently from 72a394b to d343fe8 Compare October 26, 2023 14:51
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 26, 2023
@swangi-kumari
Copy link
Contributor

Hey @sccalabr ,
Pls address the CI fails
Run cargo +nightly fmt for formatting.

@sccalabr sccalabr requested a review from a team as a code owner October 27, 2023 04:22
@SanchithHegde SanchithHegde added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 28, 2023
@swangi-kumari
Copy link
Contributor

Hello @sccalabr ,
Are you still working on this issue, As I can see you have made no changes in this PR.

@sccalabr
Copy link
Contributor Author

seems like once I rebased with master my changes disappeared.

@swangi-kumari
Copy link
Contributor

Hey @sccalabr,
I have reviewed the latest changes in the main branch, and unfortunately, I did not find the necessary updates. As a result, I am closing this pull request

@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

Assignees

@sccalabr sccalabr

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sccalabr @swangi-kumari @SanchithHegde