Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): Worldline Use connector_response_reference_id as reference to merchant #2721

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(connector): Worldline Use connector_response_reference_id as reference to merchant #2721

merged 2 commits into from
Oct 31, 2023

Conversation

Harshwardhan9431
Copy link
Contributor

@Harshwardhan9431 Harshwardhan9431 commented Oct 29, 2023 •
edited by deepanshu-iiitu

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

#2351

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Make any Payment for connector Worldline and see that you are getting "reference_id" field in the payments response of hyperswitch. It should not be null.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Harshwardhan9431 Harshwardhan9431 requested a review from a team as a code owner October 29, 2023 15:30
@Harshwardhan9431 Harshwardhan9431 changed the title feat(connector): [Worldline]Use connector_response_reference_id as reference to merchant feat(connector): Worldline Use connector_response_reference_id as reference to merchant Oct 29, 2023
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 29, 2023
@swangi-kumari swangi-kumari linked an issue Oct 29, 2023 that may be closed by this pull request
[FEATURE]: [Worldline] Use connector_response_reference_id as reference to merchant #2351
Closed
2 tasks
srujanchikke
srujanchikke approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for the PR @Harshwardhan9431

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into juspay:main with commit a261f1a Oct 31, 2023
15 of 16 checks passed
@deepanshu-iiitu
Copy link
Contributor

Hey @Harshwardhan9431 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@swangi-kumari swangi-kumari added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2023
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@Harshwardhan9431 @Abhicodes-crypto
feat(connector): Worldline Use connector_response_reference_id as r…
b7c54ac 
…eference to merchant (#2721)
kashif-m pushed a commit that referenced this pull request Nov 13, 2023
@Harshwardhan9431
feat(connector): Worldline Use connector_response_reference_id as r…
25e726c 
…eference to merchant (#2721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

Assignees

@Harshwardhan9431 Harshwardhan9431

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Worldline] Use connector_response_reference_id as reference to merchant
5 participants
@Harshwardhan9431 @deepanshu-iiitu @swangi-kumari @srujanchikke @Gnanasundari24