Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Braintree connector integration #30

Merged
merged 5 commits into from Dec 6, 2022
Merged

feat: Braintree connector integration #30

merged 5 commits into from Dec 6, 2022

Conversation

zereraz
Copy link
Contributor

@zereraz zereraz commented Nov 27, 2022 •
edited by Sangamesh26

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Added the Braintree connector.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

added Braintree base url in config files

Motivation and Context

To add Braintree connector

How did you test it?

Did a successful payment on Braintree sandbox.

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@zereraz zereraz self-assigned this Nov 27, 2022
@zereraz zereraz changed the base branch from main to 3DS2_Integration November 27, 2022 10:00
@zereraz zereraz changed the base branch from 3DS2_Integration to main November 27, 2022 10:00
SanchithHegde
SanchithHegde requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested some minor changes.

I'm assuming this is a WIP PR. Let me know if it is indeed WIP, I'll update the title to indicate the same.

crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree/transformers.rs Show resolved Hide resolved
crates/router/src/connector/braintree/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/lib.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-in-progress Status: Implementation is underway labels Nov 27, 2022
@SanchithHegde SanchithHegde changed the title Braintree connector feat: Braintree connector integration Nov 27, 2022
Narayanbhat166
Narayanbhat166 requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Narayanbhat166 Narayanbhat166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the suggested changes

@zereraz zereraz added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-in-progress Status: Implementation is underway labels Dec 1, 2022
SanchithHegde
SanchithHegde requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor set of changes, please address them. Other than that, looks good to me!

Also, could you please update the checklist items in #56 to indicate the PRs in which the checked items were included?

Something along the lines of the following snippet should be good:

### Payment Methods
 - [x] Card #30

crates/router/src/connector/braintree/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Outdated Show resolved Hide resolved
crates/router/src/connector/braintree.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde linked an issue Dec 1, 2022 that may be closed by this pull request
Braintree Connector Checklist #56
Open
16 tasks
@SanchithHegde SanchithHegde removed a link to an issue Dec 1, 2022
Braintree Connector Checklist #56
Open
16 tasks
@zereraz zereraz mentioned this pull request Dec 2, 2022
Open
16 tasks
SanchithHegde
SanchithHegde approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I'm assuming the rest of the items will be taken up in separate PRs.

@zereraz
Copy link
Contributor Author

zereraz commented Dec 2, 2022 •
edited

Looks good to me! I'm assuming the rest of the items will be taken up in separate PRs.

yes separate PRs

@zereraz zereraz removed the request for review from jarnura December 2, 2022 09:22
@Narayanbhat166 Narayanbhat166 removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 4, 2022
@jarnura jarnura merged commit e581676 into main Dec 6, 2022
@jarnura jarnura deleted the braintree-connector branch December 6, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@zereraz zereraz

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zereraz @jarnura @SanchithHegde @Narayanbhat166