-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): added api for the deleting config key #3554
Conversation
Made the changes please have a look |
Co-authored-by: Kartikeya Hegde <karthihegde010@gmail.com>
Co-authored-by: Kartikeya Hegde <karthihegde010@gmail.com>
@tanbirali Compilation is failing and many things are being missed here. I have fixed them in this commit 089551b. Can you do git fetch https://github.com/juspay/hyperswitch.git delete-config-api
git cherry-pick 089551b69e64f13968f93e1d3707e2262bac068b on your PR |
Oh I need help, I think I have messed up, here what I did, I fetched the url you shared conflict aroused to accepted the incoming changes, then staged them and committed them as well, then ran the cherry pick command which responded with nothing to commit and when I am trying to push I am getting you have not concluded your cherry pick, can you help me figure it out. |
I am not sure why would fetch cause conflicts, but
And continue with the above changes I suggested, Make sure you are on your branch where you are making changes |
Done as you told let me know if it worked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the PR, @tanbirali!
Type of Change
Description
Added the api to delete config key
Fixes #3488
How did you test it?
It should return 404
Checklist
cargo +nightly fmt --all
cargo clippy