Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [checkout] add giropay and iDEAL #4177

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Rupesh-0001
Copy link

@Rupesh-0001 Rupesh-0001 commented Mar 22, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added Giropay and iDEAL payment methods with Checkout.com

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #4181 (Also see: #4142).

How did you test it?

Made payments using giropay and iDEAL with checkout.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Rupesh-0001 Rupesh-0001 requested a review from a team as a code owner March 22, 2024 10:19
@Rupesh-0001 Rupesh-0001 changed the title feat(connector): [checkout] add giropay feat(connector): [checkout] add giropay and iDEAL Mar 23, 2024
@swangi-kumari
Copy link
Contributor

Hello @Rupesh-0001 ,
Please run cargo clippy --all-features --all-targets and resolve all the lints.

@Rupesh-0001
Copy link
Author

Hello @Rupesh-0001 , Please run cargo clippy --all-features --all-targets and resolve all the lints.

Hi @swangi-kumari , done with the code formatting to resolve the lints.

@srujanchikke
Copy link
Contributor

srujanchikke commented Apr 4, 2024

Made payments using giropay and iDEAL with checkout.

Hi @Rupesh-0001 , Could you please resolve conflicts and also are you able to enable ideal and giropay for checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing iDEAL and Giropay payment methods with Checkout.com
4 participants