-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump error-stack
from version 0.3.1
to 0.4.1
#4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error-stack
from version 0.3.1
to 0.4.1
189599e
to
47c7a22
Compare
…` and remove `into_report()` This was scripted and done by means of search-replace.
…IMIT` and `ORDER BY` SQL clauses
…d currency coversion modules
…count, merchant connector account, business profile modules
… authorization modules
…yment links modules
47c7a22
to
22d10fd
Compare
Rebased on current main (7b337ac). |
kashif-m
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved this commit - 2455732
Narayanbhat166
approved these changes
Apr 1, 2024
ArjunKarthik
approved these changes
Apr 1, 2024
ShankarSinghC
approved these changes
Apr 1, 2024
dracarys18
approved these changes
Apr 1, 2024
lsampras
approved these changes
Apr 1, 2024
sai-harsha-vardhan
approved these changes
Apr 1, 2024
prajjwalkumar17
approved these changes
Apr 1, 2024
ThisIsMani
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes looks fine.
pixincreate
added a commit
that referenced
this pull request
Apr 1, 2024
* 'main' of github.com:juspay/hyperswitch: refactor(core): removed the processing status for payment_method_status (#4213) docs(README): remove link to outdated early access form build(deps): bump `error-stack` from version `0.3.1` to `0.4.1` (#4188) chore(version): 2024.04.01.0 feat(mandates): allow off-session payments using `payment_method_id` (#4132) ci(CI-pr): determine modified crates more deterministically (#4233) chore(config): add billwerk base URL in deployment configs (#4243) feat(payment_method): API to list countries and currencies supported by a country and payment method type (#4126) chore(version): 2024.03.28.0 refactor(config): allow wildcard origin for development and Docker Compose setups (#4231) fix(core): Amount capturable remain same for `processing` status in capture (#4229) fix(euclid_wasm): checkout wasm metadata issue (#4198) fix(trustpay): [Trustpay] Add error code mapping '800.100.100' (#4224) feat(connector): [billwerk] add connector template code (#4123) fix(connectors): fix wallet token deserialization error (#4133) fix(log): adding span metadata to `tokio` spawned futures (#4118) chore(version): 2024.03.27.0 fix(connector): [CRYPTOPAY] Skip metadata serialization if none (#4205) fix(connector): [Trustpay] fix deserialization error for incoming webhook response for trustpay and add error code mapping '800.100.203' (#4199) fix(core): make eci in AuthenticationData optional (#4187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR updates the
error-stack
dependency from version0.3.1
to0.4.1
. As part of this update, they've deprecated theIntoReport
trait and itsinto_report()
method, which is quite a big change, given the size of our codebase.You can find the changelog here: https://github.com/hashintel/hash/blob/main/libs/error-stack/CHANGELOG.md
The PR can easily be reviewed one commit at a time. When doing so, please skip the second commit on this PR (title: "chore: replace
error_stack::IntoReport
witherror_stack::ResultExt
and removeinto_report()
"), since it was scripted, involving the following commands (gsed
being the GNUsed
tool on MacOS):All other commits involved manual changes and need to be reviewed. I have also grouped changes based on teams which own the parts of code, for easier reviews.
Motivation and Context
Catching up with our dependencies.
How did you test it?
It should work as long as the code compiles (and CI checks pass). I've also done a round of sanity testing by successfully creating payments using Postman.
Checklist
cargo +nightly fmt --all
cargo clippy