Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [multisafepay] integrated giropay and iDEAL #4219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devnamrits
Copy link

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

I have added the fields required as per the multisafepay API contract in the below mentioned file.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Changes are done at crates/router/src/connector/multisafepay/transformers.rs.

Motivation and Context

This PR fixes #4218 as mentioned in discussion #4143 .

How did you test it?

I've tested it with multisafepay Postman suite as present in the code. I checked the redirect link that was coming after creating the payment. I've tested Payments-Create and Payments-Retrieve API. I checked the link on the browser. Also, I'm attaching the screenshots for reference.

Screenshot 2024-03-27 at 8 57 05 AM Screenshot 2024-03-27 at 8 59 02 AM Screenshot 2024-03-27 at 8 58 47 AM Screenshot 2024-03-27 at 8 58 38 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@devnamrits devnamrits requested a review from a team as a code owner March 27, 2024 04:19
@devnamrits
Copy link
Author

Please check @sudhirrnanda @c10n3 .

I have a few doubts as well:

  • What is the concept of Redirect and Direct? Because for iDEAL, there are three options on the API doc:
  1. Redirect
  2. Direct
  3. QR.
    So if we have to implement all three then we will have to write separate matches for BankRedirectData for obtaining the value of Type::Redirect or Type::Direct.
  • I am very new to Rust. Do we have configured some commands in cargo within this project where if there are code changes in the server script reruns itself? As of now, I have to retrigger the command. Also, the build takes too much time. Once the build is completed the server also takes a considerable amount of time to start. Or its the inherent behaviour in this tech stack?

@AkshayaFoiger AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating Giropay and iDEAL payment methods with multisafepay
2 participants