feat(opensearch): refactoring #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivor-juspay
requested review from
lsampras,
ShivanshMathurJuspay and
sagarnaikjuspay
|
Co-authored-by: Sanchith Hegde <22217505+SanchithHegde@users.noreply.github.com>
ivor-juspay
added
C-refactor
SanchithHegde
previously approved these changes
Apr 10, 2024
Comment on lines
+180
to
+185
| #[cfg(feature = "olap")] | ||
| let opensearch_client = conf | ||
| .opensearch | ||
| .get_opensearch_client() | ||
| .await | ||
| .expect("Failed to create opensearch client"); |
There was a problem hiding this comment.
do we not start the application if opensearch is not set up? Only if this is enabled via a config, then we can fail the application startup
lsampras
approved these changes
Apr 29, 2024
ShivanshMathurJuspay
approved these changes
May 2, 2024
SanchithHegde
removed
the
S-waiting-on-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
refactoring opensearch to module structure
Additional Changes
Motivation and Context
refactoring
How did you test it?
test cases added below
(verify sanity of all global search endpoints)
Checklist
cargo +nightly fmt --allcargo clippy