feat(core): [Payouts] Add access_token flow for Payout Create and Fulfill flow #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-core
kashif-m
reviewed
Apr 18, 2024
kashif-m
requested changes
Apr 18, 2024
crates/api_models/src/enums.rs
Outdated
| @@ -134,6 +134,22 @@ pub enum Connector { | |||
| } | |||
|
|
|||
| impl Connector { | |||
| #[cfg(feature = "payouts")] | |||
| pub fn supports_create_payout_in_router(&self, payout_method: PayoutType) -> bool { | |||
| matches!((self, payout_method), (Self::Paypal, PayoutType::Wallet)) | |||
There was a problem hiding this comment.
PayoutType::Card should also be considered here
crates/api_models/src/enums.rs
Outdated
| @@ -134,6 +134,22 @@ pub enum Connector { | |||
| } | |||
|
|
|||
| impl Connector { | |||
| #[cfg(feature = "payouts")] | |||
| pub fn supports_create_payout_in_router(&self, payout_method: PayoutType) -> bool { | |||
There was a problem hiding this comment.
Can we name this supports_instant_payout?
| @@ -62,6 +62,7 @@ pub async fn add_access_token< | |||
| .connector_name | |||
| .supports_access_token(router_data.payment_method) | |||
| { | |||
| // requires_later | |||
kashif-m
previously approved these changes
Apr 22, 2024
sahkal
reviewed
Apr 22, 2024
Comment on lines
36
to
43
| match connector_access_token.access_token_result.as_ref() { | ||
| Ok(access_token) => { | ||
| router_data.access_token = access_token.clone(); | ||
| } | ||
| Err(connector_error) => { | ||
| router_data.response = Err(connector_error.clone()); | ||
| } | ||
| } |
sahkal
previously approved these changes
Apr 22, 2024
kashif-m
previously approved these changes
Apr 23, 2024
sahkal
previously approved these changes
Apr 23, 2024
sai-harsha-vardhan
approved these changes
Apr 23, 2024
kashif-m
approved these changes
Apr 23, 2024
sahkal
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Access token flow is added for payout create and payout fulfill flow.
Additional Changes
Motivation and Context
How did you test it?
This cannot be tested because the connector for which this change has been made for is yet not merged.
Note: Should not break current sanity
Only adds access token flow for Paypal Payouts(for now)
Checklist
cargo +nightly fmt --allcargo clippy