Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(configs): add comments to configs for deployments to environments #4458

Merged
merged 2 commits into from
Apr 25, 2024
Merged

refactor(configs): add comments to configs for deployments to environments #4458

merged 2 commits into from
Apr 25, 2024

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add comments to configs for deployments to environments - sandbox.toml, production.toml

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

no testing needed

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 25, 2024
@prasunna09 prasunna09 added this to the April 2024 milestone Apr 25, 2024
@prasunna09 prasunna09 self-assigned this Apr 25, 2024
@prasunna09 prasunna09 requested a review from a team as a code owner April 25, 2024 07:05
pixincreate
pixincreate reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the same changes be done to integration_test.toml as well?

SanchithHegde
SanchithHegde reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add comments in integration_test.toml also, to keep things uniform?

config/deployments/production.toml Outdated Show resolved Hide resolved
config/deployments/production.toml Outdated Show resolved Hide resolved
config/deployments/sandbox.toml Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 9d096e6 Apr 25, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add-comments-to-configs branch April 25, 2024 10:43
@SanchithHegde SanchithHegde added C-doc Category: Documentation updates and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@pixincreate pixincreate pixincreate approved these changes

Assignees

@prasunna09 prasunna09

Labels
C-doc Category: Documentation updates
Projects
None yet
Milestone
April 2024 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prasunna09 @SanchithHegde @pixincreate @Gnanasundari24