New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(users): add password validations #4489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riddhiagrawal001
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Apr 29, 2024
ThisIsMani
approved these changes
May 2, 2024
apoorvdixit88
approved these changes
May 2, 2024
Riddhiagrawal001
changed the title
fix(users):add password validations
fix(users): add password validations
May 2, 2024
Riddhiagrawal001
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 67794da.
ThisIsMani
pushed a commit
that referenced
this pull request
May 3, 2024
This reverts commit 67794da.
Riddhiagrawal001
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 67794da.
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Closes #4412
Additional Changes
Motivation and Context
The mandatory condition for the password field was just not be empty . Following the PR, the password field will be subject to the following checks:
1.The password must be between 8 and 50 characters in length.
2.It must include at least one uppercase character.
3.It must include at least one lowercase character.
4.It must include at least one special character.
5.It must include at least one numeric character.
How did you test it?
Failure case response
Failure case response
Checklist
cargo +nightly fmt --all
cargo clippy