-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store encrypted extended card info in redis #4493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo-for-extended-card-feat
…pted-card-in-redis
Chethan-rao
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 29, 2024
Chethan-rao
changed the base branch from
main
to
merchant-info-for-extended-card-feat
April 29, 2024 13:07
Chethan-rao
changed the base branch from
merchant-info-for-extended-card-feat
to
main
April 29, 2024 13:07
Chethan-rao
changed the base branch from
main
to
merchant-info-for-extended-card-feat
April 29, 2024 13:10
…pay/hyperswitch into store-encrypted-card-in-redis
Chethan-rao
force-pushed
the
store-encrypted-card-in-redis
branch
2 times, most recently
from
April 29, 2024 16:35
d452f84
to
7313926
Compare
Chethan-rao
force-pushed
the
store-encrypted-card-in-redis
branch
from
April 30, 2024 13:40
7313926
to
af2ca2d
Compare
…pted-card-in-redis
…pted-card-in-redis
NishantJoshi00
previously approved these changes
May 1, 2024
vspecky
requested changes
May 2, 2024
Chethan-rao
force-pushed
the
store-encrypted-card-in-redis
branch
from
May 2, 2024 09:30
ee09baf
to
be2f59a
Compare
vspecky
approved these changes
May 2, 2024
apoorvdixit88
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dashboard specific changes!
srujanchikke
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No connector specific changes are present.
NishantJoshi00
approved these changes
May 2, 2024
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
While the customer is making a payment, we’ll check whether the extended card info feature is enabled through
profile_id
in the business profile. If enabled, we’ll fetch the merchantpublic_key
andttl
from config. We’ll encrypt the card using the public key and store it in redis until ttl with the key being{merchant_id}_{payment_id}_extended_card_info
.This PR also makes the
ttl
field as an optional field. the default value would be 15 min (900 seconds) and max value would be 1 hr (3600 seconds).Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy