-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Rename crate data_models to hyperswitch_domain_models #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
labels
May 2, 2024
2 tasks
Narayanbhat166
previously approved these changes
May 2, 2024
deepanshu-iiitu
requested review from
lsampras,
SanchithHegde,
vspecky,
racnan and
SamraatBansal
May 2, 2024 07:35
SamraatBansal
previously approved these changes
May 2, 2024
ThisIsMani
previously approved these changes
May 2, 2024
vspecky
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on behalf of @juspay/hyperswitch-routing
SanchithHegde
previously approved these changes
May 2, 2024
lsampras
previously approved these changes
May 2, 2024
deepanshu-iiitu
dismissed stale reviews from ThisIsMani and SamraatBansal
via
May 2, 2024 11:10
8efab32
deepanshu-iiitu
dismissed stale reviews from Narayanbhat166, vspecky, SanchithHegde, and lsampras
via
May 2, 2024 11:10
8efab32
deepanshu-iiitu
requested review from
lsampras,
SanchithHegde,
Narayanbhat166,
ThisIsMani,
SamraatBansal and
vspecky
May 2, 2024 11:10
SanchithHegde
approved these changes
May 2, 2024
SamraatBansal
approved these changes
May 2, 2024
ThisIsMani
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes looks fine.
deepanshu-iiitu
requested review from
lsampras,
Narayanbhat166 and
vspecky
and removed request for
lsampras,
Narayanbhat166 and
vspecky
May 2, 2024 11:44
Narayanbhat166
approved these changes
May 2, 2024
lsampras
approved these changes
May 2, 2024
vspecky
approved these changes
May 2, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR contains the following change:
data_models
is renamed tohyperswitch_domain_models
Additional Changes
Motivation and Context
#4514
#4515
How did you test it?
Only crate renamed hence no testing required.
Checklist
cargo +nightly fmt --all
cargo clippy