New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(billing): store payment_method_data_billing
for recurring payments
#4513
Merged
Gnanasundari24
merged 14 commits into
main
from
4641-refactor-store-payment-method-data-billing-for-recurring-payments
May 9, 2024
Merged
refactor(billing): store payment_method_data_billing
for recurring payments
#4513
Gnanasundari24
merged 14 commits into
main
from
4641-refactor-store-payment-method-data-billing-for-recurring-payments
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
May 2, 2024
sahkal
requested changes
May 2, 2024
hrithikesh026
previously approved these changes
May 3, 2024
sai-harsha-vardhan
previously approved these changes
May 3, 2024
Aprabhat19
previously approved these changes
May 3, 2024
sahkal
previously approved these changes
May 3, 2024
Narayanbhat166
dismissed stale reviews from sahkal, Aprabhat19, sai-harsha-vardhan, and hrithikesh026
via
May 3, 2024 11:37
bacc59f
sai-harsha-vardhan
previously approved these changes
May 3, 2024
hrithikesh026
previously approved these changes
May 6, 2024
sahkal
previously approved these changes
May 7, 2024
…ing-for-recurring-payments
hrithikesh026
approved these changes
May 9, 2024
sahkal
approved these changes
May 9, 2024
sai-harsha-vardhan
approved these changes
May 9, 2024
Narayanbhat166
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
May 9, 2024
Gnanasundari24
deleted the
4641-refactor-store-payment-method-data-billing-for-recurring-payments
branch
May 9, 2024 13:28
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When a card or any payment method is saved, the billing address associated with it is also stored. This has to be presented back when the payment method is listed. This PR adds support for storing and retrieving the
payment_method_billing
during listing the payment methods associated to a customer.Motivation and Context
How did you test it?
payment_method_data.billing
.Impact
Checklist
cargo +nightly fmt --all
cargo clippy