Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): Create Decision manager for User Flows #4518

Merged
merged 18 commits into from
May 2, 2024

Conversation

ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented May 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • This PR will enable APIs to get the next flow from the current flow.
  • This PR will also add a query param which will enable to access the new flows.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #4517.

How did you test it?

curl --location 'http://localhost:8080/user/v2/signin?token_only=true' \
--header 'Content-Type: application/json' \
--data-raw '{
    "email": "email",
    "password": "password"
}'

Should return with the following response

{
    "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMDYxNjE1YjAtZjI5Yi00NWIyLWJmNmItODczNTYyYWU1ODhlIiwicHVycG9zZSI6InRvdHAiLCJvcmlnaW4iOiJTaWduSW4iLCJleHAiOjE3MTQ3MTk2NDh9.GOO-ZM3KDk0yjmNo3y8SgjqCcIYCV96Lj-lhmNl2oOc",
    "token_type": "totp"
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels May 2, 2024
@ThisIsMani ThisIsMani self-assigned this May 2, 2024
@ThisIsMani ThisIsMani requested review from a team as code owners May 2, 2024 07:47
apoorvdixit88
apoorvdixit88 previously approved these changes May 2, 2024
@pixincreate pixincreate enabled auto-merge May 2, 2024 14:08
@pixincreate pixincreate added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 4b3faf6 May 2, 2024
9 of 12 checks passed
@pixincreate pixincreate deleted the user-decision-maker branch May 2, 2024 15:12
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: decision manger for user flows
6 participants