Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Move RouterData to crate hyperswitch_domain_models #4524

Merged
merged 24 commits into from
May 15, 2024

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented May 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

RouterData moved to crate hyperswitch_domain_models.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#4514
#4523

How did you test it?

Basic testing is required for all the production connectors(and payment methods) on sandbox.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@deepanshu-iiitu deepanshu-iiitu added A-core Area: Core flows C-feature Category: Feature request or enhancement labels May 2, 2024
@deepanshu-iiitu deepanshu-iiitu self-assigned this May 2, 2024
@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners May 2, 2024 13:10
@deepanshu-iiitu deepanshu-iiitu linked an issue May 2, 2024 that may be closed by this pull request
2 tasks

#[derive(Debug, Clone, serde::Deserialize)]
pub enum PaymentMethodToken {
Token(String),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider making this a Secret<String>.

Suggested change
Token(String),
Token(Secret<String>),

And make corresponding changes for the usages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

code: "HE_00".to_string(),
message: "Something went wrong".to_string(),
reason: None,
status_code: 500,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status_code: 500,
status_code: http::StatusCode::INTERNAL_SERVER_ERROR.as_u16(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/connector/payme/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows/psync_flow.rs Outdated Show resolved Hide resolved
@likhinbopanna likhinbopanna added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit ff1c2dd May 15, 2024
12 of 15 checks passed
@likhinbopanna likhinbopanna deleted the move_routerdata branch May 15, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move struct RouterData to crate hyperswitch_domain_models
4 participants