Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(postman): Remove update_mandate_id test in Cybersource collection #4526

Merged
merged 1 commit into from
May 3, 2024
Merged

ci(postman): Remove update_mandate_id test in Cybersource collection #4526

merged 1 commit into from
May 3, 2024

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented May 2, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed update mandate_id test scenario from cybersource postman collection as this feature is deprecated

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Cybersource test was failing

How did you test it?

Postman

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@likhinbopanna likhinbopanna requested a review from a team as a code owner May 2, 2024 14:40
@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 2, 2024
@likhinbopanna likhinbopanna self-assigned this May 2, 2024
pixincreate
pixincreate approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the description with the tests that failed so that everyone will which tests are failing for now?
Other than that LGTM!

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit ecc97bc May 3, 2024
12 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the remove-update-mandate-id branch May 3, 2024 05:43
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate approved these changes

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@preetamrevankar preetamrevankar Awaiting requested review from preetamrevankar

@Aprabhat19 Aprabhat19 Awaiting requested review from Aprabhat19

Assignees

@likhinbopanna likhinbopanna

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@likhinbopanna @pixincreate @Gnanasundari24