Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and pass Amount in Decimal Format #4536

Merged
merged 4 commits into from
May 3, 2024
Merged

fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and pass Amount in Decimal Format #4536

merged 4 commits into from
May 3, 2024

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented May 3, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR contains the following changes for connector Bambora:

  • Only 2 digit i.e. 25 for 2025 card expiry year will be allowed be pass in Bambora Payments Request.
  • Amount will be passed in decimal format for Authorize, Capture and Refund requests.
  • Fix Void Flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#4534
#4538

How did you test it?

  • Payments (Manual):
    Request:
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: API_KEY_HERE' \
--data '{
  "amount": 2500,
  "currency": "USD",
  "confirm": true,
  "customer_id": "StripeCustomer",
  "capture_method": "manual",
  "authentication_type": "no_three_ds",
  "payment_method": "card",
  "payment_method_type": "credit",
  "payment_method_data": {
    "card": {
      "card_number": "4030000010001234",
      "card_exp_month": "10",
      "card_exp_year": "2024",
      "card_holder_name": "Sundari Doe",
      "card_cvc": "123"
    }
  },
  "billing": {
    "address": {
      "first_name": "joseph",
      "last_name": "Doe"
    }
  },
  "browser_info": {
    "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
    "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
    "language": "nl-NL",
    "color_depth": 24,
    "screen_height": 723,
    "screen_width": 1536,
    "time_zone": 0,
    "java_enabled": true,
    "java_script_enabled": true,
    "ip_address": "127.0.0.1"
  }
}'

Response:

{
    "payment_id": "pay_LKthlJrz33C1pr55C7ib",
    "merchant_id": "merchant_1714730521",
    "status": "requires_capture",
    "amount": 2500,
    "net_amount": 2500,
    "amount_capturable": 2500,
    "amount_received": null,
    "connector": "bambora",
    "client_secret": "pay_LKthlJrz33C1pr55C7ib_secret_BaVLQyDPAxLkJFEXfCXD",
    "created": "2024-05-03T11:30:29.586Z",
    "currency": "USD",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1234",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "403000",
            "card_extended_bin": "40300000",
            "card_exp_month": "10",
            "card_exp_year": "2024",
            "card_holder_name": "Sundari Doe",
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": {
        "address": {
            "city": null,
            "country": null,
            "line1": null,
            "line2": null,
            "line3": null,
            "zip": null,
            "state": null,
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1714735829,
        "expires": 1714739429,
        "secret": "epk_74a8cad9f3c64a229b4236f6999b8c67"
    },
    "manual_retry_allowed": false,
    "connector_transaction_id": "10004723",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_LKthlJrz33C1pr55C7ib_1",
    "payment_link": null,
    "profile_id": "pro_l8ERwD92l71RbPpGZZz9",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_ybl21De1o5q31x82RpEj",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-03T11:45:29.586Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "127.0.0.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-03T11:30:31.543Z"
}
  • Capture:
    Request:
curl --location 'http://localhost:8080/payments/pay_Bnr8RRNohtyOwlEvTOjg/capture' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: API_KEY_HERE' \
--data '{
  "statement_descriptor_name": "Joseph",
  "statement_descriptor_suffix": "JS"
}'

Response:

{
    "payment_id": "pay_Bnr8RRNohtyOwlEvTOjg",
    "merchant_id": "merchant_1714730521",
    "status": "succeeded",
    "amount": 2500,
    "net_amount": 2500,
    "amount_capturable": 0,
    "amount_received": 2500,
    "connector": "bambora",
    "client_secret": "pay_Bnr8RRNohtyOwlEvTOjg_secret_F7JoawvBWk3zzTJ9o3a8",
    "created": "2024-05-03T11:27:21.382Z",
    "currency": "USD",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1234",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "403000",
            "card_extended_bin": "40300000",
            "card_exp_month": "10",
            "card_exp_year": "2024",
            "card_holder_name": "Sundari Doe",
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": {
        "address": {
            "city": null,
            "country": null,
            "line1": null,
            "line2": null,
            "line3": null,
            "zip": null,
            "state": null,
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "10004714",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_Bnr8RRNohtyOwlEvTOjg_1",
    "payment_link": null,
    "profile_id": "pro_l8ERwD92l71RbPpGZZz9",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_ybl21De1o5q31x82RpEj",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-03T11:42:21.382Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "127.0.0.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-03T11:27:32.674Z"
}
  • Payments (Automatic Capture):
    Request:
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: API_KEY_HERE' \
--data '{
  "amount": 2500,
  "currency": "USD",
  "confirm": true,
  "customer_id": "StripeCustomer",
  "capture_method": "automatic",
  "authentication_type": "no_three_ds",
  "payment_method": "card",
  "payment_method_type": "credit",
  "payment_method_data": {
    "card": {
      "card_number": "4030000010001234",
      "card_exp_month": "10",
      "card_exp_year": "2024",
      "card_holder_name": "Sundari Doe",
      "card_cvc": "123"
    }
  },
  "billing": {
    "address": {
      "first_name": "joseph",
      "last_name": "Doe"
    }
  },
  "browser_info": {
    "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
    "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
    "language": "nl-NL",
    "color_depth": 24,
    "screen_height": 723,
    "screen_width": 1536,
    "time_zone": 0,
    "java_enabled": true,
    "java_script_enabled": true,
    "ip_address": "127.0.0.1"
  }
}'

Response:

{
    "payment_id": "pay_7KsO7eanoa25U0NUwGMy",
    "merchant_id": "merchant_1714730521",
    "status": "succeeded",
    "amount": 2500,
    "net_amount": 2500,
    "amount_capturable": 0,
    "amount_received": 2500,
    "connector": "bambora",
    "client_secret": "pay_7KsO7eanoa25U0NUwGMy_secret_MIVHZVOHOByIuQyxzs8H",
    "created": "2024-05-03T11:36:55.259Z",
    "currency": "USD",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1234",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "403000",
            "card_extended_bin": "40300000",
            "card_exp_month": "10",
            "card_exp_year": "2024",
            "card_holder_name": "Sundari Doe",
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": {
        "address": {
            "city": null,
            "country": null,
            "line1": null,
            "line2": null,
            "line3": null,
            "zip": null,
            "state": null,
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1714736215,
        "expires": 1714739815,
        "secret": "epk_ec99b66693a14bf180eba0f525c07cd0"
    },
    "manual_retry_allowed": false,
    "connector_transaction_id": "10004725",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_7KsO7eanoa25U0NUwGMy_1",
    "payment_link": null,
    "profile_id": "pro_l8ERwD92l71RbPpGZZz9",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_ybl21De1o5q31x82RpEj",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-03T11:51:55.258Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "127.0.0.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-03T11:36:57.592Z"
}
  • Refunds:
    Request:
curl --location 'http://localhost:8080/refunds' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: API_KEY_HERE' \
--data '{
  "payment_id": "pay_Bf0CmzVjSJCBVt5e6n3m",
  "reason": "Customer returned product",
  "refund_type": "instant",
  "metadata": {
    "udf1": "value1",
    "new_customer": "true",
    "login_date": "2019-09-10T10:11:12Z"
  }
}'

Response:

{
    "refund_id": "ref_ksDchUYhgBlvAYz2maZ2",
    "payment_id": "pay_Bf0CmzVjSJCBVt5e6n3m",
    "amount": 2500,
    "currency": "USD",
    "status": "succeeded",
    "reason": "Customer returned product",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "error_message": null,
    "error_code": null,
    "created_at": "2024-05-03T11:38:14.960Z",
    "updated_at": "2024-05-03T11:38:14.960Z",
    "connector": "bambora",
    "profile_id": "pro_l8ERwD92l71RbPpGZZz9",
    "merchant_connector_id": "mca_ybl21De1o5q31x82RpEj"
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-bug Category: Bug labels May 3, 2024
@deepanshu-iiitu deepanshu-iiitu self-assigned this May 3, 2024
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner May 3, 2024 10:28
This was linked to issues May 3, 2024
[BUG] [BAMBORA] Payments Failing Due to Wrong Card Expiry Year #4534
Open
[BUG] [BAMBORA] Amount not being passed in Decimal format #4538
Open
@deepanshu-iiitu deepanshu-iiitu changed the title fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and pass amount in decimal format May 3, 2024
@deepanshu-iiitu deepanshu-iiitu changed the title fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and pass amount in decimal format fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and pass Amount in Decimal Format May 3, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit d5d9006 May 3, 2024
9 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the bambora-expiry-year-fix branch May 3, 2024 13:03
SamraatBansal pushed a commit that referenced this pull request May 3, 2024
@deepanshu-iiitu @SamraatBansal
:fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and …
4e7481a 
…pass Amount in Decimal Format (#4536)
deepanshu-iiitu added a commit that referenced this pull request May 6, 2024
@deepanshu-iiitu
fix(connector): [BAMBORA] Restrict Card Expiry Year to 2 Digits and p…
e838ae3 
…ass Amount in Decimal Format (#4536)
@deepanshu-iiitu deepanshu-iiitu mentioned this pull request May 6, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
4 participants
@deepanshu-iiitu @SamraatBansal @srujanchikke @Gnanasundari24