-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(business_profile): feature add a config to use billing
as payment_method_billing
#4557
Merged
likhinbopanna
merged 5 commits into
main
from
4833-feature-add-a-config-to-use-billing-as-payment_method_billing
May 8, 2024
Merged
feat(business_profile): feature add a config to use billing
as payment_method_billing
#4557
likhinbopanna
merged 5 commits into
main
from
4833-feature-add-a-config-to-use-billing-as-payment_method_billing
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
May 6, 2024
hrithikesh026
previously approved these changes
May 6, 2024
sai-harsha-vardhan
previously approved these changes
May 6, 2024
ThisIsMani
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes looks fine.
Aprabhat19
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing specific changes looks good
…payment_method_billing
Narayanbhat166
dismissed stale reviews from Aprabhat19, ThisIsMani, sai-harsha-vardhan, and hrithikesh026
via
May 7, 2024 12:45
84ceb40
swangi-kumari
approved these changes
May 7, 2024
hrithikesh026
approved these changes
May 7, 2024
Aprabhat19
approved these changes
May 7, 2024
ThisIsMani
approved these changes
May 7, 2024
sai-harsha-vardhan
approved these changes
May 7, 2024
Narayanbhat166
changed the title
feat(billing): feature add a config to use
feat(business_profile): feature add a config to use May 7, 2024
billing
as payment_method_billing
billing
as payment_method_billing
likhinbopanna
deleted the
4833-feature-add-a-config-to-use-billing-as-payment_method_billing
branch
May 8, 2024 06:17
Narayanbhat166
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
May 9, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for a config which controls whether to use the
billing
aspayment_method_billing
. Based on this config the address is unified and accessed at the connector module. This also affects the payment method list to either populate or not populate the billing fields.Additional Changes
This PR modifies the API contract
A new field called
use_billing_as_payment_method_billing
is added to business profile create and update.This PR modifies the database schema
A new field called
use_billing_as_payment_method_billing
is added to business profile table.Motivation and Context
Impact
How did you test it?
billing
details in payment.Checklist
cargo +nightly fmt --all
cargo clippy