ci(cypress): Fix card expiry for savecard flows #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
likhinbopanna
approved these changes
May 8, 2024
SamraatBansal
approved these changes
May 9, 2024
SanchithHegde
approved these changes
May 9, 2024
| @@ -295,20 +295,20 @@ Cypress.Commands.add("createConfirmPaymentTest", (createConfirmPaymentBody, deta | |||
| }); | |||
|
|
|||
| // This is consequent saved card payment confirm call test(Using payment token) | |||
| Cypress.Commands.add("saveCardConfirmCallTest", (confirmBody, det, globalState) => { | |||
| Cypress.Commands.add("saveCardConfirmCallTest", (SaveCardConfirmBody,det,globalState) => { | |||
There was a problem hiding this comment.
Nit: variable naming, can be taken in a separate PR.
Suggested change
| Cypress.Commands.add("saveCardConfirmCallTest", (SaveCardConfirmBody,det,globalState) => { | |
| Cypress.Commands.add("saveCardConfirmCallTest", (saveCardConfirmBody,det,globalState) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
-Resolved an issue in the savecard flow where card expiry was incorrectly sourced from the confirmBody.json, resulting in failures. Now, only the payment_token is utilized, ensuring successful payment transactions.
-This pull request includes refactoring of the card_pm details to accommodate the addition of banks and wallet flows.
Additional Changes
Motivation and Context
To enhance test coverage for wallet and bank redirect flows.
How did you test it?
Ran the test manually
Checklist
cargo +nightly fmt --allcargo clippy