Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add payment method type duplication check for google_pay #5023

Merged
merged 3 commits into from
Jun 19, 2024
Merged

feat(router): add payment method type duplication check for google_pay #5023

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0c0216
feat(router): add payment method type duplication check for google_pay
ShankarSinghC Jun 18, 2024
3f17fb2
address pr comments
ShankarSinghC Jun 19, 2024
6e24c1c
address pr comments
ShankarSinghC Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions crates/router/src/core/payments/tokenization.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to rename the customer_apple_pay_saved_pm_id_option variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rename it.

Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,10 @@ where
}
},
None => {
let customer_apple_pay_saved_pm_id_option = if payment_method_type
let customer_saved_pm_id_option = if payment_method_type
== Some(api_models::enums::PaymentMethodType::ApplePay)
|| payment_method_type
== Some(api_models::enums::PaymentMethodType::GooglePay)
{
match state
.store
Expand All @@ -530,8 +532,7 @@ where
Ok(customer_payment_methods) => Ok(customer_payment_methods
.iter()
.find(|payment_method| {
payment_method.payment_method_type
== Some(api_models::enums::PaymentMethodType::ApplePay)
payment_method.payment_method_type == payment_method_type
})
.map(|pm| pm.payment_method_id.clone())),
Err(error) => {
Expand All @@ -552,10 +553,8 @@ where
Ok(None)
}?;

if let Some(customer_apple_pay_saved_pm_id) =
customer_apple_pay_saved_pm_id_option
{
resp.payment_method_id = customer_apple_pay_saved_pm_id;
if let Some(customer_saved_pm_id) = customer_saved_pm_id_option {
resp.payment_method_id = customer_saved_pm_id;
} else {
let pm_metadata =
create_payment_method_metadata(None, connector_token)?;
Expand Down
Loading