Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(merchant_account): add back api_key field for backward compatibility #761

Merged
merged 9 commits into from
Mar 17, 2023
Merged

refactor(merchant_account): add back api_key field for backward compatibility #761

merged 9 commits into from
Mar 17, 2023

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR adds back the api_key field in the merchant_account table temporarily. This change is a temporary one which would be rolled back once all our teams have migrated their applications/services to use the api_keys table and endpoints.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

The migrations can be found at up.sql and down.sql.

Motivation and Context

Backward compatibility.

How did you test it?

Verified that the same API keys are being stored in both the merchant_account and api_keys tables.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

P.S.: I'd prefer not having to make this change in the first place.

@SanchithHegde SanchithHegde added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-database-changes Metadata: This PR involves database schema changes C-refactor Category: Refactor labels Mar 16, 2023
@SanchithHegde SanchithHegde self-assigned this Mar 16, 2023
@jarnura jarnura enabled auto-merge March 16, 2023 18:14
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 16, 2023
@jarnura jarnura disabled auto-merge March 17, 2023 09:47
@jarnura jarnura merged commit 661dd48 into main Mar 17, 2023
@jarnura jarnura deleted the reintroduce-merchant-account-api-key branch March 17, 2023 10:00
This was referenced Mar 21, 2023
Closed
Merged
Merged
SanchithHegde added a commit that referenced this pull request May 6, 2023
@SanchithHegde
revert: refactor(merchant_account): add back api_key field for back…
0445455 
…ward compatibility (#761)

This reverts commit 661dd48.

The `api_key` field was added to the `merchant_account` table for backwards compatibility purposes.
Now that it is no longer needed, this commit removes the field.
@SanchithHegde SanchithHegde mentioned this pull request May 6, 2023
Merged
15 tasks
SanchithHegde added a commit that referenced this pull request May 10, 2023
@SanchithHegde
revert: refactor(merchant_account): add back api_key field for back…
f481abb 
…ward compatibility (#761) (#1062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@dracarys18 dracarys18 Awaiting requested review from dracarys18

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@SanchithHegde SanchithHegde

Labels
A-core Area: Core flows C-refactor Category: Refactor M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SanchithHegde @jarnura @Gnanasundari24