-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(merchant_account): add back api_key
field for backward compatibility
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95bfcfc.
jarnura
approved these changes
Mar 16, 2023
Gnanasundari24
approved these changes
Mar 17, 2023
This was referenced Mar 21, 2023
Merged
Merged
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-refactor
Category: Refactor
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds back the
api_key
field in themerchant_account
table temporarily. This change is a temporary one which would be rolled back once all our teams have migrated their applications/services to use theapi_keys
table and endpoints.Additional Changes
The migrations can be found at
up.sql
anddown.sql
.Motivation and Context
Backward compatibility.
How did you test it?
Verified that the same API keys are being stored in both the
merchant_account
andapi_keys
tables.Checklist
cargo +nightly fmt --all
cargo clippy
P.S.: I'd prefer not having to make this change in the first place.