Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(masking): PII improvements #77

Merged
merged 18 commits into from
Dec 13, 2022
Merged

refactor(masking): PII improvements #77

merged 18 commits into from
Dec 13, 2022

Conversation

kos-for-juspay
Copy link
Contributor

@kos-for-juspay kos-for-juspay commented Dec 6, 2022 •
edited

Type of Change

  • Refactoring

Motivation and Context

Apply suggestions from code review #65
Closes #107

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@kos-for-juspay kos-for-juspay changed the title WIP: refactor(masking): PII improvements refactor(masking): PII improvements Dec 7, 2022
ashokkjag
ashokkjag reviewed Dec 12, 2022
View reviewed changes
crates/common_utils/src/pii.rs Outdated Show resolved Hide resolved
crates/masking/src/strong_secret.rs Show resolved Hide resolved
crates/masking/src/abs.rs Show resolved Hide resolved
@ashokkjag ashokkjag merged commit 124048c into main Dec 13, 2022
@kos-for-juspay kos-for-juspay mentioned this pull request Dec 13, 2022
Closed
@kos-for-juspay kos-for-juspay deleted the orca-684-pii-improvements branch December 15, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkjag ashokkjag ashokkjag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use subtle crate for constant-time comparison
2 participants
@kos-for-juspay @ashokkjag