Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): add authorize, capture, void, psync, refund, rsync for Forte connector #955

Merged
merged 23 commits into from
May 4, 2023
Merged

feat(connector): add authorize, capture, void, psync, refund, rsync for Forte connector #955

merged 23 commits into from
May 4, 2023

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Apr 21, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Updating support for Forte payment gateway
Payment Method: card
Supported payment flows:

Authorize
Capture
Void
PSync
Refund
RSync

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-04-26 at 6 18 26 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 21, 2023
@prasunna09 prasunna09 self-assigned this Apr 21, 2023
@prasunna09 prasunna09 requested review from a team as code owners April 21, 2023 18:34
@prasunna09 prasunna09 mentioned this pull request Apr 25, 2023
Closed
5 tasks
ArjunKarthik
ArjunKarthik requested changes Apr 25, 2023
View reviewed changes
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Show resolved Hide resolved
crates/router/tests/connectors/forte.rs Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 25, 2023
jagan-jaya
jagan-jaya requested changes Apr 25, 2023
View reviewed changes
crates/router/src/connector/forte.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/forte/transformers.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/forte.rs Show resolved Hide resolved
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 25, 2023
jagan-jaya
jagan-jaya previously approved these changes Apr 25, 2023
View reviewed changes
@prasunna09 prasunna09 dismissed stale reviews from jagan-jaya and jarnura via c830bc3 May 3, 2023 10:02
jagan-jaya
jagan-jaya previously approved these changes May 3, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik previously approved these changes May 3, 2023
View reviewed changes
@jarnura jarnura added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-ready-for-merge labels May 3, 2023
@prasunna09 prasunna09 dismissed stale reviews from ArjunKarthik and jagan-jaya via b033df6 May 3, 2023 12:36
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels May 3, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 4, 2023
@jarnura jarnura added this pull request to the merge queue May 4, 2023
@jarnura jarnura added the M-configuration-changes Metadata: This PR involves configuration changes label May 4, 2023
Merged via the queue into main with commit f0464bc May 4, 2023
4 checks passed
@SanchithHegde SanchithHegde deleted the forte-features branch May 4, 2023 19:20
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed labels May 4, 2023
This was referenced May 8, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto left review comments

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik left review comments

@HyperSwitchers HyperSwitchers HyperSwitchers left review comments

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@prasunna09 @jagan-jaya @ArjunKarthik @jarnura @Abhicodes-crypto @HyperSwitchers @SanchithHegde