Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to self-hosted runner #226

Merged
merged 12 commits into from
Jun 14, 2024
Merged

ci: Switch to self-hosted runner #226

merged 12 commits into from
Jun 14, 2024

Conversation

srid
Copy link
Collaborator

@srid srid commented Jun 13, 2024

Proudly hosted by @juspay !

Infra PR https://github.com/juspay/nixos-buffet/pull/13

Much simplifies our workflow:

image

And we get to use the builtin Nix system names directly in the workflow:

image

@srid
Copy link
Collaborator Author

srid commented Jun 13, 2024

@shivaraj-bh Getting a bunch of this in CI (our mac studio):

image

@srid
Copy link
Collaborator Author

srid commented Jun 13, 2024

Still running over 1.5 hours ... currently at apache-kafka-test

https://github.com/juspay/services-flake/actions/runs/9507348769/job/26206611624

EDIT: I'm cancelling and restarting it.

@shivaraj-bh
Copy link
Member

shivaraj-bh commented Jun 14, 2024

Still running over 1.5 hours ... currently at apache-kafka-test

https://github.com/juspay/services-flake/actions/runs/9507348769/job/26206611624

EDIT: I'm cancelling and restarting it.

I believe we might need wait_for_open_port(<port_num>), like in nixos modules: https://github.com/NixOS/nixpkgs/blob/3b3f81db169561308698b5dc0d92a03a802f4002/nixos/tests/open-webui.nix#L29C5-L29C44

@srid
Copy link
Collaborator Author

srid commented Jun 14, 2024

Added a Linux runner, but mysql-test failed:

https://github.com/juspay/services-flake/actions/runs/9520309446/job/26245492894

mysql-test> [test       ] ERROR 1045 (28000): Access denied for user 'nixbld'@'localhost' (using password: NO)

@srid
Copy link
Collaborator Author

srid commented Jun 14, 2024

I believe we might need wait_for_open_port(<port_num>), like in nixos modules: https://github.com/NixOS/nixpkgs/blob/3b3f81db169561308698b5dc0d92a03a802f4002/nixos/tests/open-webui.nix#L29C5-L29C44

The darwin build worked now. So looks to be a transient issue 🤷🏿

EDIT: The linux build has also worked!

@srid srid changed the title chore(ci): Try self-hosted runner chore(ci): Switch to self-hosted runner Jun 14, 2024
@srid srid changed the title chore(ci): Switch to self-hosted runner ci: Switch to self-hosted runner Jun 14, 2024
@srid srid marked this pull request as ready for review June 14, 2024 18:32
@srid
Copy link
Collaborator Author

srid commented Jun 14, 2024

All passes, except the llm example fails to build on rosetta:

       error: Package ‘python3.11-jaxlib-0.4.28’ in /nix/store/63lvc59rjz075kb1f11xww2x2xqpw1pn-source/pkgs/development/python-modules/jaxlib/bin.nix:228 is marked as broken, refusing to evaluate.

Note that the CI for main branch no longer builds on Intel mac, as macos-latest is now an alias for macos-14

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners

image

I'll comment out rosetta and file a new issue for it.

@srid srid mentioned this pull request Jun 14, 2024
@srid
Copy link
Collaborator Author

srid commented Jun 14, 2024

Need to address github rate limits. That's the only thing to do before merging this PR.

@srid srid merged commit 86acbd5 into main Jun 14, 2024
3 checks passed
@srid srid deleted the ci-selfhosted branch June 14, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants