postgres: add socketDir option #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnalotoski
commented
Jan 17, 2024
johnalotoski
commented
- Postgres: Fix a build failure when initialDatabase schema is null
- Postgres: Add a socketDir config option which defaults to config.dataDir and allows customization of socketDir for users who do not wish it fixed to dataDir
- Also, sockets are limited to around 100 chars
- In the case that the default or desired dataDir absolute path exceeds this char limit, postgres will fail to start if it is also used for socketDir
- In this case, dataDir can remain as desired and socketDir can be set separately to a shorter absolute path
shivaraj-bh
reviewed
Jan 17, 2024
johnalotoski
force-pushed
the
pgsocket
branch
4 times, most recently
from
5837850
to
75cd590
Compare
|
@johnalotoski You can rebase with main and the CI should pass |
* Defaults to config.dataDir * Allows customization of socketDir for users who do not wish it fixed to dataDir * Sockets are limited to around [100 chars](https://linux.die.net/man/7/unix): * In the case that the default or desired dataDir absolute path exceeds this char limit, postgres will fail to start if it is also used for socketDir * In this case, dataDir can remain as desired and socketDir can be set separately to a shorter absolute path
johnalotoski
force-pushed
the
pgsocket
branch
from
75cd590
to
80f9574
Compare
|
Rebased and ready for workflow approval. |
|
LGTM! Merging |
shivaraj-bh
added a commit
to nammayatri/nammayatri
that referenced
this pull request
Jan 29, 2024
….nix unix sockets are supposed to be under a specific size limit, which can easily be crossed if your project is deep in the directory tree. To avoid this we can set a default socket dir at $HOME. For more details, refer to the PR in services-flake: juspay/services-flake#77
hkmangla
pushed a commit
to nammayatri/nammayatri
that referenced
this pull request
Jan 29, 2024
….nix unix sockets are supposed to be under a specific size limit, which can easily be crossed if your project is deep in the directory tree. To avoid this we can set a default socket dir at $HOME. For more details, refer to the PR in services-flake: juspay/services-flake#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.