Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudocode for Buying and Selling Stocks (No Restriction) #44

Closed
ghost opened this issue Oct 18, 2019 · 4 comments
Closed

Pseudocode for Buying and Selling Stocks (No Restriction) #44

ghost opened this issue Oct 18, 2019 · 4 comments
Labels
good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Oct 18, 2019

The second version on Leetcode (You can buy and sell any number of times).

@ghost ghost added the good first issue Good for newcomers label Oct 18, 2019
@lepasq
Copy link
Contributor

lepasq commented Mar 24, 2020

Hi! I'd like to contribute to your repository and created a .tex file for this Leetcode problem. I'd love to get some feedback!

main.pdf

@ghost
Copy link
Author

ghost commented Mar 28, 2020

Hi. Sorry for the delayed response.

  1. I would generally prefer one based indexing in pseudocodes.
  2. Can you make in boldface?
  3. If possible, can you include a short explanation at the end?

Thanks

@lepasq
Copy link
Contributor

lepasq commented Mar 30, 2020

Hi. Sorry for the delayed response.

1. I would generally prefer one based indexing in pseudocodes.

2. Can you make `in` boldface?

3. If possible, can you include a short explanation at the end?

Thanks

Thank you for your feedback.

I applied the suggested changes and added a small walkthrough. What do you think about it?
main_version 2.pdf

@ghost
Copy link
Author

ghost commented Mar 31, 2020

Looks good. A minor point, for i = 1 to len-1.

Also, it's better to post the TEX code so that the repository size isn't unnecessarily increased. (I can anyway generate them from my side).

Please make a pull request for the same (following the naming conventions).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant