Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blocking calls on main ktor server dispatcher coroutine #157

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

Denire
Copy link
Contributor

@Denire Denire commented Mar 29, 2021

#156 broke ktor-server routings

since version 1.4.2 ktor-server requires to invoke blocking calls (like receiveStream) on separate coroutine context to avoid blocking server request-handling coroutines.

This fixes it by delegating blocking call to IO dispatcher.

@Denire Denire requested a review from morfeusys March 29, 2021 15:57
@Denire Denire merged commit 6962fc6 into master Mar 31, 2021
@Denire Denire deleted the ktor-server-blocking-calls-on-main-dispatcher branch March 31, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants