Implement delegated properties on BotContext #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denire
approved these changes
Jan 17, 2022
core/src/main/kotlin/com/justai/jaicf/helpers/context/BotContextProperty.kt
Show resolved
Hide resolved
core/src/main/kotlin/com/justai/jaicf/helpers/context/BotContextProperty.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| fun <V> tempProperty( | ||
| key: String? = null, | ||
| saveDefault: Boolean = false, |
There was a problem hiding this comment.
Temp property cannot be saved or removed
There was a problem hiding this comment.
Can you, please, clarify what do you mean exactly?
I think it can be both saved and removed during single request execution.
It cannot be "persisted", but I don't use this word.
morfeusys
approved these changes
Feb 8, 2022
morfeusys
reviewed
Mar 3, 2022
There was a problem hiding this comment.
@nikvoloshin please extend JAICF documentation with this feature description
veptechno
approved these changes
Mar 17, 2022
nikvoloshin
force-pushed
the
feature/botcontext-delegates
branch
from
c8d1ba3
to
cd66800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handy functions
clientProperty,sessionPropertyandtempPropertyfor easy defining extension properties onBotContext.Also allows defining extensions on any class by providing
BotContextselector: