Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move data/key mapping out of @dandi/data and @dandi/data-pg #18

Closed
2 tasks done
DanielSchaffer opened this issue Oct 4, 2018 · 0 comments
Closed
2 tasks done

Move data/key mapping out of @dandi/data and @dandi/data-pg #18

DanielSchaffer opened this issue Oct 4, 2018 · 0 comments
Labels
feature New feature or request
Milestone
v1.0.0

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Oct 4, 2018 •
edited
Loading

We should not be doing any modification of the data coming out of data clients from within the data client libraries. This is causing problems with JSON blob columns that use UUID style keys, since the data mapper is trying to convert them to camelCase.

  • building on Refactor model validation #13, add an option to transform the data before constructing the target model
  • use existing @Json decorator to optionally ignore transforms for JSON fields
@DanielSchaffer DanielSchaffer added the feature New feature or request label Oct 4, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Oct 4, 2018
DanielSchaffer added a commit that referenced this issue Oct 5, 2018
@DanielSchaffer
@dandi/model-validation refactor to separate model building from vali…
cfe006a 
…dation; remove key/object mapping logic from @dandi/data and @dandi/data-pg

supports #13, #18
DanielSchaffer added a commit that referenced this issue Oct 5, 2018
@DanielSchaffer
fix missing model-validation renames
01bc6ab 
supports #13, #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@DanielSchaffer