Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formalize output formatting/rendering #24

Closed
6 tasks done
DanielSchaffer opened this issue Dec 12, 2018 · 0 comments
Closed
6 tasks done

formalize output formatting/rendering #24

DanielSchaffer opened this issue Dec 12, 2018 · 0 comments
Labels
@dandi/mvc feature New feature or request
Projects
v1.0.0
Milestone
v1.0.0

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Dec 12, 2018 •
edited
Loading

  • ControllerResults - generally data only (remove JsonResult)
  • Renderers - can be registered at the application-level (json/xml/etc), or at the route-level (views - html).
  • Switch output formatting based on Accept header
  • Default to JSON when Accept is ambiguous
  • Default to text/html if a view is defined
  • allow returning text/plain
@DanielSchaffer DanielSchaffer added feature New feature or request @dandi/mvc labels Dec 12, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Dec 12, 2018
@DanielSchaffer DanielSchaffer mentioned this issue Dec 12, 2018
Closed
2 tasks
@DanielSchaffer DanielSchaffer added this to To do in v1.0.0 Feb 22, 2019
@DanielSchaffer DanielSchaffer moved this from To do to In progress in v1.0.0 Feb 26, 2019
DanielSchaffer pushed a commit that referenced this issue Feb 27, 2019
feat(mvc) - formalize mvc output rendering
4b793e0 
progress #24
DanielSchaffer pushed a commit that referenced this issue Feb 27, 2019
fix(mvc) - fix build
e067420 
progress #24
DanielSchaffer pushed a commit that referenced this issue Feb 28, 2019
fix(mvc) - object renderer implementation tests
a82f8b9 
progress #24
DanielSchaffer pushed a commit that referenced this issue Feb 28, 2019
feat(mvc) - object renderer view engine integration
4e307da 
progress #24
@DanielSchaffer DanielSchaffer mentioned this issue Feb 28, 2019
Open
4 tasks
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
feat(mvc) - formalize mvc output rendering
30e0a1b 
closes #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
feat(core): add Resolver.canResolve(token) method
7260c95 
- include `Module` in `RegisterableTypes`
- add `@dandi/core/testing` entry point to expose internal functions and objects

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
feat(core-testing): add registration utilities to TestContext
1c9b070 
- also add `underTest` helper to skip singleton-ing behavior of factory providers being tested

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
feat(mvc-express): Make MvcExpressModule act like a normal module
053d78c 
BREAKING

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
chore(examples/simple-express-rest-api): update example to use new ex…
fcf00c9 
…press module

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
feat(mvc-express): Make MvcExpressModule act like a normal module
bf46773 
BREAKING CHANGE: removes defaults helpers in favor of overriding with providers

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
chore(examples/simple-express-rest-api): update example to use new ex…
f15ae54 
…press module

supports #24
v1.0.0 automation moved this from In progress to Done Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@dandi/mvc feature New feature or request
Projects
v1.0.0
  
Done
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@DanielSchaffer