Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formalize output formatting/rendering #24

Closed
6 tasks done
DanielSchaffer opened this issue Dec 12, 2018 · 0 comments
Closed
6 tasks done

formalize output formatting/rendering #24

DanielSchaffer opened this issue Dec 12, 2018 · 0 comments
Labels
@dandi/mvc feature New feature or request
Projects
Milestone

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Dec 12, 2018

  • ControllerResults - generally data only (remove JsonResult)
  • Renderers - can be registered at the application-level (json/xml/etc), or at the route-level (views - html).
  • Switch output formatting based on Accept header
  • Default to JSON when Accept is ambiguous
  • Default to text/html if a view is defined
  • allow returning text/plain
@DanielSchaffer DanielSchaffer added feature New feature or request @dandi/mvc labels Dec 12, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Dec 12, 2018
@DanielSchaffer DanielSchaffer added this to To do in v1.0.0 Feb 22, 2019
@DanielSchaffer DanielSchaffer moved this from To do to In progress in v1.0.0 Feb 26, 2019
DanielSchaffer pushed a commit that referenced this issue Feb 27, 2019
DanielSchaffer pushed a commit that referenced this issue Feb 27, 2019
DanielSchaffer pushed a commit that referenced this issue Feb 28, 2019
DanielSchaffer pushed a commit that referenced this issue Feb 28, 2019
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
- include `Module` in `RegisterableTypes`
- add `@dandi/core/testing` entry point to expose internal functions and objects

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
- also add `underTest` helper to skip singleton-ing behavior of factory providers being tested

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
BREAKING CHANGE: removes defaults helpers in favor of overriding with providers

supports #24
DanielSchaffer pushed a commit that referenced this issue Mar 1, 2019
v1.0.0 automation moved this from In progress to Done Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dandi/mvc feature New feature or request
Projects
v1.0.0
  
Done
Development

No branches or pull requests

1 participant