Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test coverage: @dandi/model-validation #6

Closed
3 tasks done
DanielSchaffer opened this issue Jul 25, 2018 · 0 comments
Closed
3 tasks done

test coverage: @dandi/model-validation #6

DanielSchaffer opened this issue Jul 25, 2018 · 0 comments
Assignees
@DanielSchaffer
Labels
feature New feature or request
Milestone
v1.0.0

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Jul 25, 2018 •
edited
Loading

Add test coverage for the following items:

  • DecoratorModelValidator
  • primitive type validators
  • UuidTypeValidator
@DanielSchaffer DanielSchaffer added feature New feature or request good first issue labels Jul 25, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Jul 25, 2018
@DanielSchaffer DanielSchaffer changed the title test coverage: @dandi/model-validation test coverage: @dandi/model-validation Jul 25, 2018
DanielSchaffer added a commit that referenced this issue Jul 26, 2018
@DanielSchaffer
add tests for DecoratorModelValidator
6b3814b 
progress #6
@DanielSchaffer DanielSchaffer self-assigned this Jul 26, 2018
DanielSchaffer added a commit that referenced this issue Jul 26, 2018
@DanielSchaffer
finish tests for DecoratorModelValidator
7671804 
- refactored metadata validation so that it happens for all types, not just primitives; this allows, for example, min/max length to apply to arrays
- fixed MetadataValidationError adding "undefined" string to message if no message was defined

progress #6
DanielSchaffer added a commit that referenced this issue Jul 26, 2018
@DanielSchaffer
finish tests for PrimitiveTypeValidator and related validators
a3dadfa 
- BooleanTypeValidator no longer attempts to use the output of toString() for validation - this seems like a super edge case

progress #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielSchaffer DanielSchaffer

Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@DanielSchaffer