Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test coverage: @dandi/mvc #8

Closed
6 tasks done
DanielSchaffer opened this issue Jul 25, 2018 · 0 comments
Closed
6 tasks done

test coverage: @dandi/mvc #8

DanielSchaffer opened this issue Jul 25, 2018 · 0 comments
Assignees
@DanielSchaffer
Labels
feature New feature or request
Milestone
v1.0.0

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Jul 25, 2018 •
edited

Add test coverage for the following items:

  • DecoratorRouteGenerator
  • mergeAuthorization in authorization.metadata.ts
  • authorizedDecorator
  • DefaultRouteInitializer
  • requestBodyProvider in request.body.decorator.ts
  • getCorsConfig
@DanielSchaffer DanielSchaffer added feature New feature or request good first issue labels Jul 25, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Jul 25, 2018
@DanielSchaffer DanielSchaffer self-assigned this Jul 31, 2018
DanielSchaffer added a commit that referenced this issue Jul 31, 2018
@DanielSchaffer
add tests for mergeAuthorization, DecoratorRouteGenerator
0ff4ead 
- the `authorization` and `cors` properties of AuthorizationMetadata can no longer be booleans, and are now optional
- mergeAuthorization now returns undefined when no arguments are passed, or when none of the arguments have authorization conditions

progress #8
DanielSchaffer added a commit that referenced this issue Aug 1, 2018
@DanielSchaffer
add tests for @Authorized
72a03b7 
progress #8
DanielSchaffer added a commit that referenced this issue Aug 1, 2018
@DanielSchaffer
add tests for DefaultRouteInitializer
968207b 
- break authProvider logic out into AuthProviderFactory service
- add missing library exports

progress #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielSchaffer DanielSchaffer

Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@DanielSchaffer