Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot updates for theme #25

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

max06
Copy link
Contributor

@max06 max06 commented Jun 10, 2023

This workflow will semi-automatically update just the docs in the gemfile and the corresponding lock-file.

This doesn't only keep the template updated, it will also create PRs for every repository derived from this template.

Example PR: max06#2

A change to the README.md will come soon, this feature needs a settings change in the created repository.

@just-the-docs/maintainers I'd love to hear your opinions!

@mattxwang
Copy link
Member

Thanks for this PR, it's certainly an interesting idea!

Two questions:

  • I'm a bit wary of adding more third-party actions, which themselves need to be kept in sync. Could we not instead have a dependabot template action? From my experience, the Ruby support works relatively well, and it's first-party / a part of GitHub
  • any idea why the Netlify deploy is failing here? we haven't changed any of the actual build!

@max06
Copy link
Contributor Author

max06 commented Jun 16, 2023

I have no clue about netlify. Some builds are going through, some are failing.

I'll get deeper into dependabot. Most of the stuff I used here was copied from another project of mine, didn't think about that.

@max06 max06 force-pushed the auto-update branch 3 times, most recently from ae2a78a to 85a9aba Compare June 19, 2023 11:54
@max06
Copy link
Contributor Author

max06 commented Jun 19, 2023

Changed to dependabot - I'll wait for the first PR before marking this as ready

@mattxwang
Copy link
Member

Just getting to this now -- will this run if it's not merged into main? I don't think so, right?

@max06
Copy link
Contributor Author

max06 commented Jun 25, 2023

I have merged it into my own main branch of a fork - it should tell us if it works before we ship untested things to users.

@max06 max06 marked this pull request as ready for review July 24, 2023 18:37
@max06
Copy link
Contributor Author

max06 commented Jul 24, 2023

After fixing a wrong schema, it works now.

@mattxwang mattxwang changed the title Auto update Enable dependabot updates for theme Jul 24, 2023
@max06 max06 merged commit 552377b into just-the-docs:main Jul 24, 2023
6 checks passed
@max06 max06 deleted the auto-update branch July 24, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants