Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Alignment #103

Closed
amirmasoudabdol opened this issue Mar 15, 2019 · 2 comments
Closed

Horizontal Alignment #103

amirmasoudabdol opened this issue Mar 15, 2019 · 2 comments
Labels
enhancement next-minor-release next minor release bump

Comments

@amirmasoudabdol
Copy link

Is your feature request related to a problem? Please describe.
While vertical alignment does a lot, I have faced several situations where I had to horizontally align elements as well. This mainly occurs when dealing with images.

Describe the solution you'd like
I think it'd be nice to provide set of classes, similar to what is already there for vertical alignment but for Horizontal alignment. This could be simple .floatright, .floatleft, and .center, or other more customizable options.

Describe alternatives you've considered
I am aware that I can technically define these myself and solve the problem but I thought it would be nice to natively add them to the theme as well.

Additional context
I'm not a CSS developer, I can start preparing a PR, but I don't think it'd keep up to the standard. However, if you think this is a good starting point, I can go ahead and start the PR, and leave the cleanup to you. 😄

Thanks for the them btw, it's awesome!

@pmarsceill pmarsceill added this to Backlog in Release Tracker via automation May 29, 2019
@pmarsceill
Copy link
Collaborator

I will get this in the next release. Thanks!

Release Tracker automation moved this from Backlog to Done May 29, 2019
@pmarsceill pmarsceill reopened this May 29, 2019
@pmarsceill pmarsceill removed this from Done in Release Tracker May 29, 2019
@pmarsceill pmarsceill added this to Backlog in Release Tracker via automation May 29, 2019
@pmarsceill pmarsceill moved this from Backlog to v0.2.6 in Release Tracker May 29, 2019
@pmarsceill pmarsceill added the next-minor-release next minor release bump label Aug 14, 2019
@pmarsceill pmarsceill removed this from v0.2.6 in Release Tracker May 1, 2020
@pmarsceill pmarsceill mentioned this issue May 1, 2020
@pdmosses
Copy link
Contributor

@pmarsceill it appears this issue was implemented in 0.2.9, and can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement next-minor-release next minor release bump
Projects
None yet
Development

No branches or pull requests

3 participants