Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon support #118

Closed
mikebeaton opened this issue Apr 22, 2019 · 1 comment · Fixed by #132
Closed

favicon support #118

mikebeaton opened this issue Apr 22, 2019 · 1 comment · Fixed by #132

Comments

@mikebeaton
Copy link

I was wondering, would there be any chance of including some favicon code in _includes/head.html?

Something like:

  {% if site.favicon != nil %}
    <link rel="shortcut icon" href="{{ site.favicon | absolute_url }}">
  {% endif %}
@pmarsceill pmarsceill added this to Backlog in Release Tracker via automation May 2, 2019
@pmarsceill
Copy link
Collaborator

This has been in my mental queue for a while now, feel free to open a PR if you'd like to contribute it to the next release.

Release Tracker automation moved this from Backlog to Done May 13, 2019
KeenanLukeOM referenced this issue in Mi-Lan/dxDaoBlog Feb 3, 2022
V1.1 initial PR, expanded upon in #115 and #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants