Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard up/down scrolling #48

Closed
egmontkob opened this issue Dec 1, 2018 · 2 comments
Closed

Keyboard up/down scrolling #48

egmontkob opened this issue Dec 1, 2018 · 2 comments
Assignees

Comments

@egmontkob
Copy link

Hi,

When the pages load, the keyboard Up and Down arrow do nothing. They scroll neither the left-side navbar, nor the right-side content area. You need to click on the text once for them to work.

Ideally I think the right-side main pane should receive the keyboard focus (or what is it called?) on page load so that it can be scrolled, like on most homepages. (I understand that with the two independently scrolling vertical panes the layout of this page is not like most pages out there.)

Do you happen to know how to do it? I spent like two minutes trying to figure out how to give "focus" to an element that's not input focusable by its nature, I came across tabindex=0 which I've tried to add to main-content-wrap or main-content, no success so far. Guess I should try a bit harder :) but I think you have more experience here.

@pmarsceill pmarsceill self-assigned this Dec 14, 2018
@pmarsceill pmarsceill added this to Backlog in Release Tracker via automation Dec 14, 2018
@pmarsceill pmarsceill moved this from Backlog to v0.2.2 in Release Tracker Dec 14, 2018
@pmarsceill
Copy link
Collaborator

@egmontkob can you check out the preview branch to see if this functions as you expect it? https://pmarsceill-75eb703e3e.drafts.github.io/just-the-docs/

@egmontkob
Copy link
Author

Yes, it does. Thanks a lot!

I spent some more time trying to fix it, but eventually gave up. I could make the right pane focused using tabindex, but then it was outlined with a dotted line.

As far as I can see, this is what you did too, plus some CSS hack to hide that dotted line. Apparently the concept of keyboard focus of non-input fields doesn't exist in HTML??

Release Tracker automation moved this from v0.2.2 to Done Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants