Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nan should be in dependencies #25

Closed
vjpr opened this issue Oct 15, 2017 · 1 comment
Closed

nan should be in dependencies #25

vjpr opened this issue Oct 15, 2017 · 1 comment

Comments

@vjpr
Copy link

vjpr commented Oct 15, 2017 •
edited

As it is used in binding.gyp.

This breaks when using pnpm package manager.
@justadudewhohacks
Copy link
Owner

Ohh that's not good. Does this package manager not install peer dependencies? Nan is a dependency of macro-inferno. However, I will include it, since I am planning to replace the macro lib anyways.

justadudewhohacks added a commit that referenced this issue Oct 17, 2017
@justadudewhohacks
Merge pull request #27 from justadudewhohacks/#25
3cc62ed 
add nan to dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjpr @justadudewhohacks