Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow get's on 3D matrices #261

Merged
merged 1 commit into from Apr 19, 2018
Merged

Allow get's on 3D matrices #261

merged 1 commit into from Apr 19, 2018

Conversation

asilvas
Copy link
Contributor

@asilvas asilvas commented Apr 18, 2018 •
edited

Regarding #259

Ideally I'd also like to support getDataAsArray, but this looked like the simplest workaround.

@justadudewhohacks
Copy link
Owner

Okay if that actually works. I assumed that you would have to call mat.at and mat.set in a different way, because right now they are called with mat.at(row, col).

@asilvas
Copy link
Contributor Author

asilvas commented Apr 19, 2018

set won't work as it is right now, I only changed the arg check to be consistent with at, which does support Vec3d & Vec4d. I spent a little time trying to get getDataAsArray working but with no luck.

@justadudewhohacks justadudewhohacks merged commit 901caf8 into justadudewhohacks:master Apr 19, 2018
@justadudewhohacks justadudewhohacks mentioned this pull request Aug 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asilvas @justadudewhohacks