Issue #28: Fix getimagesize() failing when images require fseek. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch currently breaks inline uploads where you click the "upload" button instead of submitting the form itself. |
…ek." This reverts commit 8182a95.
This fixes an issue where clicking "remove" on a file field form item would throw a warning.
|
I've changed how this works to use a seekable stream, which fixes #ajax uploads at the cost of patching (for now) the upstream SDK. I've updated composer.json to pull that in. I also did a more comprehensive audit of everywhere that calls getParams(), fixing an issue where removing a file with AJAX broke. |
|
deviantintegral/aws-sdk-php@c29fcb6#commitcomment-11839567 got a +1, so I'm merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.