Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to use other language than English for backend launch #3093

Closed
8 tasks done
JustArchi opened this issue Dec 6, 2023 · 2 comments
Closed
8 tasks done

A way to use other language than English for backend launch #3093

JustArchi opened this issue Dec 6, 2023 · 2 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

JustArchi commented Dec 6, 2023

Checklist

Enhancement purpose

The issue is that after every launch of ASF, I'm starting receiving emails in English. These emails are notifications about successful purchase/sale on the Steam community market, receipts about paying for games. And after program finish own work, I need relaucnh my own Steam client to refresh my language preferences. Is there any way to run the server side of the Steam client in my native language to continue receiving notifications as I did before?

https://steamcommunity.com/groups/archiasf/discussions/1/4035850502437013626

Solution

I'm quite sure there is a property in SK2 somewhere that influences the language we're announcing with to Steam network. Let's find it and see what we can do with it.

Why currently available solutions are not sufficient?

As per above.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

No response

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. labels Dec 6, 2023
@Abrynos
Copy link
Contributor

Abrynos commented Dec 6, 2023

O oh. That sounds like an interesting thing I've never thought about before because I always keep my stuff in english anyways :D I'll be looking forward to community opinions on this.

@JustArchi
Copy link
Member Author

Update: we have client_language in proto accepting values such as "english", "ukrainian", "russian". Solution for now is to take current culture, convert english name to lowercase and pass it along, which should do the trick.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
@JustArchi JustArchi added the 🏁 Finished Issues marked with this label were finished already and no further work is required on them. label Jun 17, 2024
@JustArchi JustArchi removed the 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. label Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

2 participants