This repository has been archived by the owner on Apr 30, 2020. It is now read-only.
User resolver #390
Merged
User resolver #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burenbot
approved these changes
Mar 19, 2017
burenbot
approved these changes
Mar 19, 2017
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 1 commit behind the You can see more details about this review at https://ebertapp.io/github/justarrived/just-match-web/pulls/390. |
buren
reviewed
Mar 20, 2017
| import {Resolve} from '@angular/router'; | ||
| import {User} from '../../models/user'; | ||
| import {UserProxy} from '../../services/proxy/user-proxy.service'; | ||
|
|
||
| @Injectable() | ||
| export class UserResolver implements Resolve<User> { | ||
| private readonly storageAuthorizationData: string = 'authorizationData'; | ||
| private readonly storageSessionKey: string = 'sessionData'; |
There was a problem hiding this comment.
fyi this will logout all users on deploy
There was a problem hiding this comment.
Yes, might want to change the string back, but I thought session was a better name 👍
@buren
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔪 User manager and auth manager.
User now resolved via resolver before init if there is a session.
Also added loading indicators on various components before data load etc.
When the language is changed and logged in -> user is reloaded ->whole page is dimmed with a loading indicator until user is resolved again.