Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script tag included regardless of admin configuration for enabling it #47

Closed
adamj88 opened this issue Jan 16, 2020 · 1 comment · Fixed by #48
Closed

Script tag included regardless of admin configuration for enabling it #47

adamj88 opened this issue Jan 16, 2020 · 1 comment · Fixed by #48

Comments

@adamj88
Copy link
Contributor

adamj88 commented Jan 16, 2020

Do you want to request a feature or report a bug?

bug

Bug: What is the current behavior?

Script tag is included when admin configuration "Enable Sentry script tag" is set to 'No'

Bug: What is the expected behavior?

Script tag respects admin config

Bug: What is the proposed solution?

Update Helper/Data.php to correctly use admin configuration.

What is the version of Magento and of Sentry extension you are using? Always use the latest version of the extension one before opening a bug issue.

Magento 2.3.3 and Justbetter Sentry v2.2.1

** More Detail **

Believe it was this change which introduced it: 1f60b01#diff-735f70c1f948ebbd90915b1548d93432R161

@indykoning
Copy link
Member

indykoning commented Feb 11, 2020

The PR with the fix has been merged and released with version 2.2.0 and is available to update with composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants