-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Magento Cloud #80
Comments
It would be a good approach for Magento Cloud |
I think treating the settings as module configuration would be the best approach to this because why would we read the environment variables manually when a more flexible solution already exists 😉 I would prefer the deployment config to still be allowed for backwards compatibility 🙂 |
Has anyone made a solution on how to enable Sentry on Adobe Commerce Cloud? I'd really like to implement this in a project. I can see if I can implement the logic to make it available in the module configuration, but I don't want to re-invent the wheel here. |
This has been added in https://github.com/justbetter/magento2-sentry/releases/tag/3.5.0 🚀 |
Hey guys!
I really like this extension I would love to use it on Magento cloud projects but I found a big blocker. You are using
DeploymentConfig
to get all the configuration sentry settings. The problem with that is you are recollecting these options either from env.php or config.php. For on-premise projects is not a big issue to add all the settings into the env.php file but for Magento Cloud projects isn't possible.Magento Cloud recommends using environment variables to override settings like
CONFIG__DEFAULT__SENTRY__DSN
which in this case is not an option because the extension is using Magento Deployment Configuration.I just forked your project and I would love to propose one of two solutions.
What do you think?
The text was updated successfully, but these errors were encountered: